[CRIU] [PATCH v2 00/13] Refactor pid_ns helpers creation

Andrei Vagin avagin at virtuozzo.com
Wed May 17 16:19:48 PDT 2017


Applied, thanks
On Tue, May 16, 2017 at 07:25:44PM +0300, Kirill Tkhai wrote:
> This series mostly simplifies do_create_pid_ns_helper(), which
> is currently too large and complex. It uses modified patches from
> "[PATCH 0/3] Synchronize forking on mutex" patchset to escape
> of ns_last_pid file lock.
> 
> The result of patchset is decreasing of do_create_pid_ns_helper()
> code and improving its readability. See the final result
> in patch [12/13].
> 
> v2: Kill flock() of ns_last_pid at all
> 
> ---
> 
> Kirill Tkhai (13):
>       restore: Simplify do_fork_with_pid()
>       restore: Simplify do_fork_with_pid() #2
>       restore: Delete excess code in call_clone_fn()
>       restore: Always set real pid in restore_task_with_children()
>       pid_ns: Rename do_destroy_pid_ns_helper()
>       pid_ns: Pass namespace init task to do_create_pid_ns_helper()
>       pid_ns: Simplify do_create_pid_ns_helper() using ns helpers
>       pid_ns: Move parent pid_ns's helper check to create_pid_ns_helper()
>       namespace: Group unlocking/closing operations in do_create_pid_ns_helper()
>       forking: Introduce last_pid_mutex and helpers
>       forking: Use last_pid_mutex for synchronization during clone()
>       pid_ns: Do cleanups in do_create_pid_ns_helper()
>       pid_ns: Close sk in case of pid_ns_helper_sock() fails
> 
> 
>  criu/cr-restore.c       |   56 ++++++++--------------------
>  criu/img-remote-proto.c |   16 --------
>  criu/include/rst_info.h |   13 +++++++
>  criu/namespaces.c       |   94 ++++++++++++++---------------------------------
>  criu/pie/restorer.c     |   34 +++++++----------
>  5 files changed, 70 insertions(+), 143 deletions(-)
> 
> --
> Signed-off-by: Kirill Tkhai <ktkhai at virtuozzo.com>


More information about the CRIU mailing list