[CRIU] [PATCH 0/2] files: Add ability to skip certain files for size check

Cyrill Gorcunov gorcunov at gmail.com
Thu Mar 23 09:09:36 PDT 2017


On Thu, Mar 23, 2017 at 06:50:23PM +0300, Pavel Emelyanov wrote:
> On 03/23/2017 06:20 PM, Cyrill Gorcunov wrote:
> > During containers testing we discovered that if some application
> > ran acct() syscall the size check upon restore will fail becaue
> > kernel updates the file at task exit.
> > 
> > At the moment there is no way to figure out which file been used
> > in acct() syscall so we should provide a user an option to be
> > able to skip such specific files on both dump and restore.
> > 
> > For this sake --skip-fsize-path option introduced.
> 
> I don't like the idea of such an option :( I'd rather agree on
> some quirk inside the criu code to skip files of that kind.

The option is just fine. Otherwise we leave customers without
ability to restore applications which use acct() syscall. How
mayn quirks we will have to keep? It is not hw which is mostly
immutable but rather anyone can call for acct() and ruine
restore procedure.


More information about the CRIU mailing list