[CRIU] [PATCH] Remove bogus check in check_features

Adrian Reber adrian at lisas.de
Tue Mar 14 09:43:00 PDT 2017


From: Adrian Reber <areber at redhat.com>

The check_features RPC function required that both known fields are
present. Without those fields it exited with an error. If RPC users
where not specifying all parameters it would fail. It should, however,
be possible to only check for a subset of options.

Each supported option is checked separately anyway in the forked criu
which does the actual check.

Removing the check also enables RPC clients with older protobuf
definitions to use the feature check.

Signed-off-by: Adrian Reber <areber at redhat.com>
---
 criu/cr-service.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/criu/cr-service.c b/criu/cr-service.c
index 69e1a55..78142b0 100644
--- a/criu/cr-service.c
+++ b/criu/cr-service.c
@@ -832,13 +832,6 @@ static int handle_feature_check(int sk, CriuReq * msg)
 	feat.has_lazy_pages = 1;
 	feat.lazy_pages = false;
 
-	/* Check if the requested feature check can be answered. */
-	if ((msg->features->has_mem_track != 1) ||
-	    (msg->features->has_lazy_pages != 1)) {
-		pr_warn("Feature checking for unknown feature.\n");
-		goto out;
-	}
-
 	pid = fork();
 	if (pid < 0) {
 		pr_perror("Can't fork");
-- 
2.9.3



More information about the CRIU mailing list