[CRIU] [PATCH v2 05/17] s390:criu: Enable s390 in criu

Dmitry Safonov 0x7f454c46 at gmail.com
Fri Jun 30 16:03:12 MSK 2017


2017-06-29 22:24 GMT+03:00 Michael Holzheu <holzheu at linux.vnet.ibm.com>:
> Add s390 parts to common code files.
>
> Signed-off-by: Michael Holzheu <holzheu at linux.vnet.ibm.com>

Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>

...
> @@ -202,17 +208,24 @@ err_oob:
>         return -EFAULT;
>  }
>
> +/* On s390x Hash_t is 64 bit */
> +#ifdef __s390x__
> +typedef unsigned long Hash_t;
> +#else
> +typedef Word_t Hash_t;
> +#endif

Just for prettifying a bit, may we move it to platform-depended
Elf types definitions to criu/include/util-vdso.h?
Just a preference, may be left if it looks better for you as-is.

-- 
             Dmitry


More information about the CRIU mailing list