[CRIU] [PATCH] kdat: allow to override build time

[Pavel Emelyanov]

On 06/30/2017 12:59 PM, Bernhard M. Wiedemann wrote:
> in order to allow for reproducible builds.
> See https://reproducible-builds.org/ for why this is good
> and https://reproducible-builds.org/specs/source-date-epoch/
> for the definition of this variable.

Thanks, Brenhard!

Acked-by: Pavel Emelyanov <xemul at virtuoozo.com>

Is that the only thing that's required to make criu builds reproducible?
Presumably not, so is there anything we can help you with to make it happen?

I'm asking because criu's "build system", as you've noticed, is homegrown
and is about to be constantly tuned and fixed (probably be replaced) in the
future. So I'd like to align those potential changes with yours :)

-- Pavel

> Signed-off-by: Bernhard M. Wiedemann <bwiedemann at suse.de>
> ---
>  criu/Makefile.crtools | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/criu/Makefile.crtools b/criu/Makefile.crtools
> index adc64ef7..6b3fbdfb 100644
> --- a/criu/Makefile.crtools
> +++ b/criu/Makefile.crtools
> @@ -1,7 +1,7 @@
>  ccflags-y		+= -iquote criu/$(ARCH)
>  ccflags-y		+= $(COMPEL_UAPI_INCLUDES)
>  CFLAGS_REMOVE_clone-noasan.o += $(CFLAGS-ASAN)
> -CFLAGS_kerndat.o	+= -DKDAT_MAGIC_2=${shell date +%s} -DKDAT_RUNDIR=\"$(RUNDIR)\"
> +CFLAGS_kerndat.o	+= -DKDAT_MAGIC_2=${shell echo $${SOURCE_DATE_EPOCH:-$$(date +%s)}} -DKDAT_RUNDIR=\"$(RUNDIR)\"
>  ldflags-y		+= -r
>  
>  obj-y			+= action-scripts.o
>