[CRIU] [PATCH 1/7] Add architecture support for s390x

[Michael Holzheu]

Am Wed, 28 Jun 2017 20:38:39 +0300
schrieb Mike Rapoport <rppt at linux.vnet.ibm.com>:

> On Wed, Jun 28, 2017 at 06:56:34PM +0200, Michael Holzheu wrote:
> > Am Wed, 28 Jun 2017 19:46:30 +0300
> > schrieb Mike Rapoport <rppt at linux.vnet.ibm.com>:
> > 
> > > Hello Michael,
> > > 
> > > On Wed, Jun 28, 2017 at 06:11:59PM +0200, Michael Holzheu wrote:
> > > > This patch adds the required functionality to make CRIU run on mainframe
> > > > z Systems machines (s390x).
> > > > 
> > > > S390x is is a 64 bit big endian CISC architecture.
> > > > 
> > > > This patch set does not include:
> > > > 
> > > >  * Support for 31 bit compat tasks
> > > >  * Support for processes that use s390 runtime instrumentation
> > > > 
> > > > Some parts of the patch have been contributed by:
> > > > 
> > > >  * Alice Frosi <alice at linux.vnet.ibm.com>
> > > > 
> > > > Reviewed-by: Alice Frosi <alice at linux.vnet.ibm.com>
> > > > Signed-off-by: Michael Holzheu <holzheu at linux.vnet.ibm.com>
> > > > ---
> [...]
> > > >  68 files changed, 2683 insertions(+), 27 deletions(-)
> > > 
> > > This is really big patch and it would be really hard to review it.
> > > 
> > > I would suggest to split it into several smaller patches.
> > > I also believe that it would be better for the review if the arch specific
> > > bits would be separated from core functionality changes.
> > 
> > I thought about that, but in the end almost all in this patch is s390
> > specific stuff. Even the few common code files have "#ifdef __s390x__".
> > 
> > Patches 2-7 are common code changes that are not 100% s390 specific.
> 
> Patches 2-7 can go in as far as I am concerned :)
> 
> > So what exactly is your suggestion for splitting up the patch?
> 
> As for the 1/7, I think you can do something like
> 
> 1. "Add compel/arch/s390", that adds all the files to compel/arch/s390
> 2. "Enable s390 in compel/" with the changes to compel/{Makefile,plugins,src}
> 3. "s390 protobuf additions" with the files that were added to images/
> 4. "Add criu/arch/s390" that adds the new files into criu/arch/s390
> 5. "Enable s390 in criu" with the rest of the changes in criu
> 6. "zdtm updates" with the tests.
> 
> At the very least you can split compel, criu and zdtm changes...

I have some problems creating the compel patch which can be built
on s390 without the other pieces.

Is there something like "make compel"?

Michael