[CRIU] [PATCH 12/12] page-xfer: Sanitize xfer core routine

Pavel Emelyanov xemul at virtuozzo.com
Thu Jun 29 13:30:49 MSK 2017


>>> -					continue;
>>> -				} else {
>>> -					flags |= PE_LAZY;
>>> -				}
>>> -			}
>>> +			flags = ppb_xfer_flags(xfer, ppb);
>>>
>>>  			if (xfer->write_pagemap(xfer, &iov, flags))
>>>  				return -1;
>>> -			if (xfer->write_pages(xfer, ppb->p[0], iov.iov_len))
>>> +			if ((flags & PE_PRESENT) && xfer->write_pages(xfer,
>>> +						ppb->p[0], iov.iov_len))
>>
>> Huh again. A newline after && ?
> 
> Yup, I'll resend.
> 

Ugh, actually no. Just moving xfer->write... on the next line makes this new
line be >80 chars, or split it again thus turning into a stairs :(

-- Pavel


More information about the CRIU mailing list