[CRIU] [PATCH 0/7] Add architecture support for s390x

[Pavel Emelyanov]

On 06/28/2017 07:11 PM, Michael Holzheu wrote:
> Hello CRIU mailing list,
> 
> This set of patches adds the s390x (64 bit mainframe) backend support to
> the CRIU checkpoint/restore tool.

That's really cool :) thanks a lot!

There's one, quite big, thing I'd like to discuss :) So far the most active community
members are x86 guys, but we already have 3 more arches (arm, aarch64 and ppc64le). 
In order not to break non-x86 heavily we've set up travis-ci jobs to constantly check
that criu compiles on non-x64 [1]. Also we have arm box and access to ppc64 VM from 
IBM and a set of jenkins jobs [2] that run tests on them.

Would you also at least add the former piece, so that we don't break compilation of your
code. And ideally, we'd like to have the latter thing too.

> The patches apply to the "criu-dev" branch on top of commit eee68d7a0
> ("aarch/vdso: include common/compiler.h before use __maybe_unused).
> 
> On s390 all tests of the zdtm testsuite succeed on Ubuntu 16.04 with kernel
> 4.8.0-34-generic execpt for the following:
> 
>  - zdtm/static/del_standalone_un
>  - zdtm/static/deleted_unix_sock
>  - zdtm/static/mnt_ext_dev
>  - zdtm/static/overmount_dev
>  - zdtm/static/overmount_fifo
>  - zdtm/static/overmount_file
>  - zdtm/static/overmount_sock
>  - zdtm/static/pthread02
>  - zdtm/static/ptrace_sig
>  - zdtm/static/scm00

Erm ... this test is marked with crfail in its .desc file, which means, that
dump MUST fail :)

>  - zdtm/static/sock_peercred
>  - zdtm/static/socket_snd_addr

And this one is marked as 'noauto' which means, that the test is a placeholder
for the functionality we want to support, so it does fail now.

How did you run the tests?

>  - zdtm/static/tempfs_overmounted
>  - zdtm/static/unlink_fstat01+
>  - zdtm/static/unlink_largefile
>  - zdtm/static/unlink_regular00
>  - zdtm/static/vfork00
>  - zdtm/transition/thread-bomb
> 
> We have not analyzed the failures yet because for us those tests also failed on
> Ubuntu for x86_64.

-- Pavel

[1] https://travis-ci.org/xemul/criu/
[2] https://ci.openvz.org/job/CRIU/