[CRIU] [PATCH 01/12] page-read: Don't try to dedup from img cache/proxy

[Mike Rapoport]

On Wed, Jun 28, 2017 at 04:46:07PM +0300, Pavel Emelyanov wrote:
> It's simply impossible (yet), so emit a warning.

Memory dump with image-cache is an interesting problem even without dedup ;-)
 
> Signed-off-by: Pavel Emelyanov <xemul at virtuozzo.com>
> ---
>  criu/pagemap.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/criu/pagemap.c b/criu/pagemap.c
> index 130e511..4a0f142 100644
> --- a/criu/pagemap.c
> +++ b/criu/pagemap.c
> @@ -433,11 +433,8 @@ static int maybe_read_page_img_cache(struct page_read *pr, unsigned long vaddr,
>  			break;
>  	}
> 
> -	if (opts.auto_dedup) {
> -		ret = punch_hole(pr, pr->pi_off, len, false);
> -		if (ret == -1)
> -			return -1;
> -	}
> +	if (opts.auto_dedup)
> +		pr_warn_once("Can't dedup from image cache\n");
> 
>  	if (ret == 0 && pr->io_complete)
>  		ret = pr->io_complete(pr, vaddr, nr);
> -- 
> 2.1.4
> 
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu
>