[CRIU] 'make install' does not honor external variables

[Dmitry Safonov]

2017-06-27 22:28 GMT+03:00 Francesco Giancane <francescogiancane8 at gmail.com>:
> Hi Dmitry,
>
> Thanks for the feedback.
>
> Here is the patch as a text. I already sent also the part 2 in which
> other variables for GCS expose same behavior. Do you want me to attach
> it right here, or you prefer discussing it in a separate thread?

In a separate thread, please.
Resend it as this one as text and fill something in patch's description.

>
> From f5d3573c3f5ed36185aa3fb67949544b857f1a55 Mon Sep 17 00:00:00 2001
> From: Francesco Giancane <francescogiancane8 at gmail.com>
> Date: Mon, 26 Jun 2017 00:29:41 +0200
> Subject: [PATCH 1/2] Makefile variable 'PREFIX' should be configurable.
>

Here should be patch's description, something like:

Currently, it's possible to specify DESTDIR for `make install`.

Make PREFIX also configurable from environment so
`PREFIX=/ DESTDIR=~/build_criu make install` will copy files into
~/build_criu directory as expected, not into ~/build_criu/usr/local/.

> Signed-off-by: Francesco Giancane <francescogiancane8 at gmail.com>
> ---
>  Makefile.install | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.install b/Makefile.install
> index 979ef0d..3606e1e 100644
> --- a/Makefile.install
> +++ b/Makefile.install
> @@ -1,6 +1,6 @@
>  #
>  # Installation paths.
> -PREFIX := /usr/local
> +PREFIX ?= /usr/local
>  BINDIR := $(PREFIX)/bin
>  SBINDIR := $(PREFIX)/sbin
>  MANDIR := $(PREFIX)/share/man
> --
> 2.9.4
> Francesco Giancane
>
> Via Paolo Braccini 46, 10141 Torino (TO)
> +393933920466
> https://it.linkedin.com/in/francesco-giancane-aa7213117
>
>
>
> 2017-06-27 21:07 GMT+02:00 Dmitry Safonov <0x7f454c46 at gmail.com>:
>> 2017-06-26 1:58 GMT+03:00 Francesco Giancane <francescogiancane8 at gmail.com>:
>>> Hi everyone,
>>> I tried to build and install the criu package from source. All went
>>> well, unless for the install part.
>>>
>>> In particular,
>>> PREFIX=/
>>> DESTDIR=~/build_criu
>>>
>>> PREFIX=${PREFIX} DESTDIR=${DESTDIR} make install
>>>
>>> resulted in installing criu packages in ~/build_criu/usr/local/,
>>> ignoring PREFIX, even if this variable should be configurable as of
>>> manual and GCS.
>>
>> Hi Francesco,
>>
>> Please, keep patch description inside, do not move it to
>> mail body. Also send it as text, not as an attachment - it's
>> easier to comment inline.
>>
>> With moved description to patch's body:
>> Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>
>>
>>>
>>> Francesco Giancane
>>>
>>> Via Paolo Braccini 46, 10141 Torino (TO)
>>> +393933920466
>>> https://it.linkedin.com/in/francesco-giancane-aa7213117
>>>
>>> _______________________________________________
>>> CRIU mailing list
>>> CRIU at openvz.org
>>> https://lists.openvz.org/mailman/listinfo/criu
>>>
>>
>>
>>
>> --
>>              Dmitry



-- 
             Dmitry