[CRIU] [PATCH] test: grow_map -- Mark as noauto

Pavel Emelyanov xemul at virtuozzo.com
Tue Jun 27 15:22:01 MSK 2017


On 06/27/2017 03:09 PM, Vasily Averin wrote:
> Pavel, 
> grow_maps fails on kernels with Stackguard fix.
> 
> http://marc.info/?l=linux-kernel&m=149814139409086&w=2
>>From Oleg Nesterov:
> "With the recent kernel changes criu should never look outside of start-end
> region reported by /proc/maps; and restore doesn't even need to know if a
> GROWSDOWN region will actually grow or not, because (iiuc) you do not need
> to auto-grow the stack vma during restore, criu re-creates the whole vma
> with the same length using MAP_FIXED and it should never write below the
> addr returned by mmap(MAP_FIXED)"

OK. Plz, add it to commit message :)

> On 2017-06-27 14:50, Pavel Emelyanov wrote:
>> On 06/27/2017 09:58 AM, Cyrill Gorcunov wrote:
>>> As requested by Andrew.
>>
>> Adnrey? What's the reason?
>>
>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>> ---
>>>  test/zdtm/static/grow_map.desc   | 1 +
>>>  test/zdtm/static/grow_map02.desc | 1 +
>>>  test/zdtm/static/grow_map03.desc | 1 +
>>>  3 files changed, 3 insertions(+)
>>>  create mode 100644 test/zdtm/static/grow_map.desc
>>>  create mode 100644 test/zdtm/static/grow_map02.desc
>>>  create mode 100644 test/zdtm/static/grow_map03.desc
>>>
>>> diff --git a/test/zdtm/static/grow_map.desc b/test/zdtm/static/grow_map.desc
>>> new file mode 100644
>>> index 000000000000..95c58b4018b3
>>> --- /dev/null
>>> +++ b/test/zdtm/static/grow_map.desc
>>> @@ -0,0 +1 @@
>>> +{'flags': 'noauto'}
>>> diff --git a/test/zdtm/static/grow_map02.desc b/test/zdtm/static/grow_map02.desc
>>> new file mode 100644
>>> index 000000000000..95c58b4018b3
>>> --- /dev/null
>>> +++ b/test/zdtm/static/grow_map02.desc
>>> @@ -0,0 +1 @@
>>> +{'flags': 'noauto'}
>>> diff --git a/test/zdtm/static/grow_map03.desc b/test/zdtm/static/grow_map03.desc
>>> new file mode 100644
>>> index 000000000000..95c58b4018b3
>>> --- /dev/null
>>> +++ b/test/zdtm/static/grow_map03.desc
>>> @@ -0,0 +1 @@
>>> +{'flags': 'noauto'}
>>>
>>
>> _______________________________________________
>> CRIU mailing list
>> CRIU at openvz.org
>> https://lists.openvz.org/mailman/listinfo/criu
>>
> .
> 



More information about the CRIU mailing list