[CRIU] [PATCH 0/18] Support descriptors sent over unix sockets (v2)

Kirill Tkhai ktkhai at virtuozzo.com
Mon Jul 31 12:05:39 MSK 2017


On 22.07.2017 03:48, Andrei Vagin wrote:
> On Mon, Jul 10, 2017 at 05:35:21PM -0700, Andrei Vagin wrote:
>> Kirill, could you review this series?
> 
> Kirill, what is your verdict?

There were several commentaries by me, which are approved by Pavel and some
are not approved. I thought, he is going to make the changes on the approved
ones, isn't he?
 
>>
>> On Mon, Jul 10, 2017 at 12:37:28PM +0300, Pavel Emelyanov wrote:
>>> It turned out, that the idea about all files having unique IDs was wrong,
>>> fifos and ttys generate reg-file entry for themselves with the same ID.
>>>
>>> Also, dgram unix sockets can be connected to self, and this wasn't handled
>>> in unix peer resolution fixlets.
>>>
>>> So here's the v2 with the above stuff taken into account. I've added two
>>> patches to make fifo and tty IDs unique, fixed find_file_desc() to count
>>> for that and tuned unix peer resolve changes to handle self-connected
>>> dgram sockets. And rebased on recent criu-dev of course.
>>>
>>> https://travis-ci.org/xemul/criu/builds/251242054
>>>
>>> -- Pavel
>>> _______________________________________________
>>> CRIU mailing list
>>> CRIU at openvz.org
>>> https://lists.openvz.org/mailman/listinfo/criu
>> _______________________________________________
>> CRIU mailing list
>> CRIU at openvz.org
>> https://lists.openvz.org/mailman/listinfo/criu


More information about the CRIU mailing list