[CRIU] [PATCH 06/11] vdso: Add a comment about rt-vdso and decreasing nr. of symbols
Dmitry Safonov
dsafonov at virtuozzo.com
Mon Jul 17 15:39:57 MSK 2017
No functional change is expected :-D
Signed-off-by: Dmitry Safonov <dsafonov at virtuozzo.com>
---
criu/pie/parasite-vdso.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/criu/pie/parasite-vdso.c b/criu/pie/parasite-vdso.c
index 5285a2c31dc7..a31363352385 100644
--- a/criu/pie/parasite-vdso.c
+++ b/criu/pie/parasite-vdso.c
@@ -214,6 +214,14 @@ static int add_vdso_proxy(VmaEntry *vma_vdso, VmaEntry *vma_vvar,
rt_vdso_addr += sym_rt->vvar_size;
}
+ /*
+ * Note: we assume that after first migration with inserted
+ * rt-vdso and trampoilines on the following migrations
+ * number of vdso symbols will not decrease.
+ * We don't save the content of original vdso under inserted
+ * jumps, so we can't remove them if on the following migration
+ * found that number of symbols in vdso has decreased.
+ */
if (vdso_redirect_calls(rt_vdso_addr, vma_vdso->start,
sym_rt, sym_img, compat_vdso)) {
pr_err("Failed to proxify dumpee contents\n");
--
2.13.1
More information about the CRIU
mailing list