[CRIU] [RFC 0/3] compel: Ship std_ string helpers

[Cyrill Gorcunov]

On Fri, Jan 27, 2017 at 09:53:42AM -0800, Kir Kolyshkin wrote:
> On 01/27/2017 09:14 AM, Cyrill Gorcunov wrote:
> > NOT FOR MERGING!
> > 
> > Hi guys, while using volatile in https://github.com/xemul/criu/issues/279
> > for a fix I think we still might go further and simply drop off all
> > builtin_ helpers but rather provide ones in std_ compel module.
> > The work is still incompelete 'cause need to look intp powerpc
> > versions of asm-optimized helpers. But just to present you
> > some preliminary results. The idea is to use std_memset/memcpy
> > explicitly where needed.
> 
> I mostly agree with the approach, we definitely need to unify this shit.
> 
> My suggestions:
> 1 move criu string.h code to compel (instead of adding and removing code)
> 2 rename functions to memcpy/memset (there's no need for any prefix in code
> which is not linked to glibc)

Well, I could drop this prefixes, but then it means we need to include
headers with the function prototipes conditionally, depending if object
is supposed to link with libc or not. In turn if they have std_ prefix
we can include them unconditionally.