[CRIU] [RFC 0/3] compel: Ship std_ string helpers

Dmitry Safonov dsafonov at virtuozzo.com
Fri Jan 27 09:30:56 PST 2017


On 01/27/2017 08:14 PM, Cyrill Gorcunov wrote:
> NOT FOR MERGING!
>
> Hi guys, while using volatile in https://github.com/xemul/criu/issues/279
> for a fix I think we still might go further and simply drop off all
> builtin_ helpers but rather provide ones in std_ compel module.
> The work is still incompelete 'cause need to look intp powerpc
> versions of asm-optimized helpers. But just to present you
> some preliminary results. The idea is to use std_memset/memcpy
> explicitly where needed.

Well, I would prefer them to be without this `std_` prefix and don't
use them explicitely where it's not needed. That would be handy.

But, I know your concern here about naming conflicts and so I'm not
objecting patches. Looks good to me, let's clean that {std_,builtin_,}*
mess.

-- 
              Dmitry


More information about the CRIU mailing list