[CRIU] [PATCH v2] criu/arch/x86/Makefile: move -Wa out of asflags

Kir Kolyshkin kir at openvz.org
Fri Jan 27 08:08:30 PST 2017


In a manner similar to one of commit 9303ed3 ("Makefiles: move
-Wa,--noexecstack out of CFLAGS"), let's move this option
from assembler to linker flags (see the abovementioned commit
for reasoning).

This fixes generating dependencies for criu/arch/x86/call32.S when using clang:

  DEP      criu/arch/x86/call32.d
clang-3.8: error: argument unused during compilation: '-Wa,--noexecstack'
  DEP      criu/arch/x86/call32.d
clang-3.8: error: argument unused during compilation: '-Wa,--noexecstack'

Signed-off-by: Kir Kolyshkin <kir at openvz.org>
---
 criu/arch/x86/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/criu/arch/x86/Makefile b/criu/arch/x86/Makefile
index 1d29cb9..6bd5ac9 100644
--- a/criu/arch/x86/Makefile
+++ b/criu/arch/x86/Makefile
@@ -4,9 +4,10 @@ ccflags-y		+= -iquote $(obj) -iquote $(SRC_DIR) -iquote $(obj)/include
 ccflags-y		+= -iquote $(SRC_DIR)/criu/include -iquote $(SRC_DIR)/include
 ccflags-y		+= $(COMPEL_UAPI_INCLUDES)
 
-asflags-y		+= -Wstrict-prototypes -Wa,--noexecstack
+asflags-y		+= -Wstrict-prototypes
 asflags-y		+= -D__ASSEMBLY__ -nostdlib -fomit-frame-pointer
 asflags-y		+= -iquote $(obj)/include
+ldflags-y		+= -z noexecstack
 
 obj-y			+= cpu.o
 obj-y			+= crtools.o
-- 
2.9.3



More information about the CRIU mailing list