[CRIU] lazy: BUG at criu/pstree.c:499

[Adrian Reber]

On Tue, Jan 10, 2017 at 06:47:48PM +0200, Mike Rapoport wrote:
> Hello Adrian,
> 
> On Tue, Jan 10, 2017 at 02:24:32PM +0100, Adrian Reber wrote:
> > Hello Mike,
> > 
> > trying to dump a process with --lazy-pages leads to:
> > 
> > $ criu dump -t 14227 -D /tmp/1 --port 27 --lazy-pages -j
> > Error (criu/pstree.c:499): BUG at criu/pstree.c:499
> > Aborted
> > 
> > Should that currently work?
> 
> Can you please check if the patch below works for you?

No, still the same error.
  
> > 		Adrian

> diff --git a/criu/crtools.c b/criu/crtools.c
> index 06b2fa7..f6e0263 100644
> --- a/criu/crtools.c
> +++ b/criu/crtools.c
> @@ -772,7 +772,7 @@ int main(int argc, char *argv[], char *envp[])
>  #endif
>  
>  	if (!strcmp(argv[optind], "page-server"))
> -		return cr_page_server(opts.daemon_mode, -1) > 0 ? 0 : 1;
> +		return cr_page_server(opts.daemon_mode, false -1) > 0 ? 0 : 1;

There is a comma missing, btw.                               ^

>  	if (!strcmp(argv[optind], "service"))
>  		return cr_service(opts.daemon_mode);

		Adrian