[CRIU] [PATCH] scripts: Add ACT_PRE_RESUME stage

[Pavel Emelyanov]

On 01/10/2017 05:21 PM, Cyrill Gorcunov wrote:
> On Tue, Jan 10, 2017 at 04:54:39PM +0300, Pavel Emelyanov wrote:
>>>>
>>>> Can you describe what exactly happens between POST_RESTORE and PRE_RESUME?
>>>
>>>  - depopulate_roots_yard (opening new files)
>>>  - network_unlock_internal (running iptables)
>>>  - attach_to_tasks (parsing procfs output: open files, allocating new memory)
>>>  - catch_tasks (same as attach_to_tasks)
>>>  - finalize_restore (allocate new memory)
>>
>> Can all this stuff happen before POST_RESUME?
> 
> It can I think, but as I already say we can't simply
> toss run-script points because it is API.

Well, we can, provided the description of the point is valid :)
Script executes when all tasks are restored and ready to be
resumed. Match? Match, let's move ;)

>>
>>> Note we've to do resume inside veX
>>
>> Cyrill, veX is not something CRIU is aware of ;)
> 
> I simply explained why we need this new run-script hook.
> Seriously it's a cheap and might be useful for other
> purposes, say for debug. Of course I can carry this custom
> patch in my vz7 criu instance (and I already do) but this
> is quite inconvenient. After all criu should fit all the
> wrappers (vz7, docker, lxc).
> .
>