[CRIU] [PATCH 1/4] compel: arch, x86 -- Make rt_sigcontext_32 members being close to kernel

Cyrill Gorcunov gorcunov at gmail.com
Tue Feb 14 06:51:13 PST 2017


On Tue, Feb 14, 2017 at 05:30:56PM +0300, Dmitry Safonov wrote:
> On 02/14/2017 01:26 PM, Cyrill Gorcunov wrote:
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> 
> Don't mind about this change, but I remember why I introduced it the
> other way then in kernel: I didn't need to handle selectors partly.
> And that simplified macro to copy them:
> 
> #define CPREG32(d)	f->compat.uc.uc_mcontext.d = r->d
> ...
> static void restore_compat_gpregs(struct rt_sigframe *f, UserX86RegsEntry
> *r)
> {
> 	CPREG32(gs);
> 	CPREG32(fs);
> 	CPREG32(es);
> 	CPREG32(ds);
> 
> So, if I don't miss anything - this will be broken afterwards.
> (not sure, why compiler didn't warn you here)
> Could you fix registers copy then?

Simply drop this particular patch then, it doesn't affect
the rest of the series.


More information about the CRIU mailing list