[CRIU] [PATCH] ppc64: Fix clobber list item for JUMP_TO_RESTORER_BLOB

Pavel Emelyanov xemul at virtuozzo.com
Tue Feb 14 05:34:04 PST 2017


On 02/14/2017 04:09 PM, Adrian Reber wrote:
> On Mon, Feb 13, 2017 at 05:01:54PM +0100, Adrian Reber wrote:
>> On Mon, Feb 13, 2017 at 11:26:43AM +0100, Laurent Dufour wrote:
>>> The JUMP_TO_RESTORER_BLOB assembly macro has been rewrote through the
>>> commit '89d6b39cfe36 ppc64: pie -- Add ppc64le relocation's
>>> processing', but the Clobber list hasn't been updated.
>>>
>>> This doesn't generate build neither runtime errors since the Clobber
>>> list was larger than needed but GCC 7 is now raising an error when an
>>> assembly macro is clobbering the r2 register.
>>>
>>> This patch fix the Clobber list to just modified registers.
>>>
>>> Fixes: 89d6b39cfe36 ("ppc64: pie -- Add ppc64le relocation's processing")
>>> Reported-by: Adrian Reber <adrian at lisas.de>
>>> Signed-off-by: Laurent Dufour <ldufour at linux.vnet.ibm.com>
>>
>> Tested-by: Adrian Reber <adrian at lisas.de>
>>
>> It compiles again:
>>
>> https://kojipkgs.fedoraproject.org/work/tasks/1536/17841536/build.log
>>
>> I was not able to actually test it yet. I am trying to get a ppc64le
>> system running with gcc-7.
> 
> I was able to install gcc-7 on a Fedora 25 test VM and got the following
> from a test run:
> 
> # ./zdtm.py run -f h -a --keep-going
> ################### 2 TEST(S) FAILED (TOTAL 293/SKIPPED 102) ###################
>  * zdtm/static/deleted_unix_sock(unknown)
>  * zdtm/static/del_standalone_un(unknown)
> ##################################### FAIL #####################################
> 
> So it seems most of the test are working. Not sure why those 2 failed.

Can you check these two individually? zdtm.py run -t zdtm/static/deleted_unix_sock

> And all test passed for: ./zdtm.py run -f ns -a --keep-going
> 
> 		Adrian
> .
> 



More information about the CRIU mailing list