[CRIU] [PATCH 1/2] compel: arch,x86 -- Drop native ia32 pieces

[Dmitry Safonov]

On 02/10/2017 02:18 PM, Cyrill Gorcunov wrote:
> It was never functional neither we plan to support
> native ia32 mode, so drop these incomplete code
> pieces out.
>
>  - Presumably we will need TASK_SIZE for compat
>    mode so I provide TASK_SIZE_IA32 for this sake
>
>  - 32 bit syscalls are remaining for a while

Just another glance - and found a minor nit:

> --- a/compel/arch/x86/src/lib/include/handle-elf.h
> +++ b/compel/arch/x86/src/lib/include/handle-elf.h
> @@ -1,17 +1,6 @@
>  #ifndef COMPEL_HANDLE_ELF_H__
>  #define COMPEL_HANDLE_ELF_H__
>
> -#ifdef CONFIG_X86_32
> -
> -#include "elf32-types.h"
> -
> -#define ELF_X86_32
> -
> -#define __handle_elf				handle_elf_x86_32
> -#define arch_is_machine_supported(e_machine)	(e_machine == EM_386)
> -
> -#else /* CONFIG_X86_64 */
> -
>  #include "elf64-types.h"
>
>  #define ELF_X86_64
> @@ -19,8 +8,6 @@
>  #define __handle_elf				handle_elf_x86_64
>  #define arch_is_machine_supported(e_machine)	(e_machine == EM_X86_64)
>
> -#endif
> -
>  extern int handle_elf_x86_32(void *mem, size_t size);

This ^ hanging extern (without realization after the patch) can be also
removed.

>  extern int handle_elf_x86_64(void *mem, size_t size);
>


-- 
              Dmitry