[CRIU] [PATCH] lazy-pages: add comments about different addresses in lazy_iov and lp_req

Mike Rapoport rppt at linux.vnet.ibm.com
Wed Feb 8 04:01:14 PST 2017


Both lazy_iov and lp_req have two fields for address/start: the run-time
address that tracks remaps, and the "dump time" address, which is required
for pagemap accesses.

Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
---
 criu/uffd.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/criu/uffd.c b/criu/uffd.c
index 6ac34f7..7649dbc 100644
--- a/criu/uffd.c
+++ b/criu/uffd.c
@@ -55,16 +55,16 @@ static mutex_t *lazy_sock_mutex;
 
 struct lazy_iov {
 	struct list_head l;
-	unsigned long base;
-	unsigned long img_base;
+	unsigned long base;	/* run-time start address, tracks remaps */
+	unsigned long img_base;	/* start address at the dump time */
 	unsigned long len;
 };
 
 struct lazy_pages_info;
 
 struct lp_req {
-	unsigned long addr;
-	unsigned long img_addr;
+	unsigned long addr;	/* actual #PF (or background) destination */
+	unsigned long img_addr;	/* the corresponding address at the dump time */
 	struct list_head l;
 };
 
-- 
1.9.1



More information about the CRIU mailing list