[CRIU] [PATCH] pipes: Restore pipe size via userns call

Cyrill Gorcunov gorcunov at virtuozzo.com
Mon Feb 6 02:39:22 PST 2017


On Mon, Feb 06, 2017 at 01:22:39PM +0300, Pavel Emelyanov wrote:
> >  
> >  static struct pipe_data_rst *pd_hash_pipes[PIPE_DATA_HASH_SIZE];
> >  
> > +typedef struct {
> > +	unsigned int	pipe_id;
> > +	size_t		size;
> > +} pipe_set_size_arg_t;
> > +
> > +static int pipe_set_size(void *arg, int fd, int pid)
> > +{
> > +	pipe_set_size_arg_t *p = arg;
> > +
> > +	pr_info("Restoring size %#zx for %#x\n", p->size, p->pipe_id);
> 
> You don't need pipe_id here, just print it before calling userns_call and
> remove this ugly pipe_set_size_arg_t.

It is *ASYNC* call, thus it's printed when it executes, which is a
way more suitable for log I think, no?


More information about the CRIU mailing list