[CRIU] [PATCH 08/11] net: allow to dump and restore more than one network namespace

Andrei Vagin avagin at virtuozzo.com
Fri Feb 3 23:38:57 PST 2017


On Fri, Feb 03, 2017 at 03:26:22PM +0300, Dmitry Safonov wrote:
> Doing UTS & IPC namespaces over your patches set, have found
> a minor thing:
> 
> 2017-02-02 3:04 GMT+03:00 Andrei Vagin <avagin at openvz.org>:
> > diff --git a/criu/pstree.c b/criu/pstree.c
> > index 833b3d0..bce7b72 100644
> > --- a/criu/pstree.c
> > +++ b/criu/pstree.c
> > @@ -14,6 +14,8 @@
> >  #include "mount.h"
> >  #include "dump.h"
> >  #include "util.h"
> > +#include "net.h"
> > +
> >  #include "protobuf.h"
> >  #include "images/pstree.pb-c.h"
> >  #include "crtools.h"
> > @@ -472,6 +474,8 @@ static int read_pstree_ids(struct pstree_item *pi)
> >         if (pi->ids->has_mnt_ns_id) {
> >                 if (rst_add_ns_id(pi->ids->mnt_ns_id, pi, &mnt_ns_desc))
> >                         return -1;
> > +               if (rst_add_ns_id(pi->ids->net_ns_id, pi, &net_ns_desc))
> > +                       return -1;
> 
> Shouldn't it be under?

Yes, it should. Thansk!

> if (pi->ids->has_net_ns_id)
> 
> -- 
>              Dmitry


More information about the CRIU mailing list