[CRIU] [PATCH v4] zdtm: Add a test to check if we can C/R ghost files with no parent dirs.

Vitaly Ostrosablin vostrosablin at virtuozzo.com
Fri Dec 8 17:51:50 MSK 2017


This is test that triggers a bug with ghost files, that was resolved in
patch "Don't fail if ghost file has no parent dirs".

Signed-off-by: Vitaly Ostrosablin <vostrosablin at virtuozzo.com>
---
 test/zdtm/static/Makefile                        |   1 +
 test/zdtm/static/unlink_multiple_largefiles.c    | 192 +++++++++++++++++++++++
 test/zdtm/static/unlink_multiple_largefiles.desc |   1 +
 3 files changed, 194 insertions(+)
 create mode 100644 test/zdtm/static/unlink_multiple_largefiles.c
 create mode 100644 test/zdtm/static/unlink_multiple_largefiles.desc

diff --git a/test/zdtm/static/Makefile b/test/zdtm/static/Makefile
index 7627828e..0c3860d8 100644
--- a/test/zdtm/static/Makefile
+++ b/test/zdtm/static/Makefile
@@ -206,6 +206,7 @@ TST_NOFILE	:=				\
 		pidns03				\
 		config_inotify_irmap		\
 		pipe03				\
+		unlink_multiple_largefiles	\
 #		jobctl00			\
 
 include ../Makefile.inc
diff --git a/test/zdtm/static/unlink_multiple_largefiles.c b/test/zdtm/static/unlink_multiple_largefiles.c
new file mode 100644
index 00000000..aaaf8d0c
--- /dev/null
+++ b/test/zdtm/static/unlink_multiple_largefiles.c
@@ -0,0 +1,192 @@
+#include <unistd.h>
+#include <errno.h>
+#include <stdlib.h>
+#include <string.h>
+#include <stdio.h>
+#include <fcntl.h>
+#include <signal.h>
+#include <limits.h>
+
+#include "zdtmtst.h"
+
+#define FSIZE 0x3B600000ULL
+#define NFILES 10
+
+const char *test_doc = "C/R of ten big (951MiB) unlinked files in root dir";
+const char *test_author = "Vitaly Ostrosablin <vostrosablin at virtuozzo.com>";
+
+void create_check_pattern(char *buf, size_t count, unsigned char seed)
+{
+	int i;
+
+	for (i = 0; i < count; i++)
+		buf[i] = seed++;
+}
+
+void compare_file_content(int fildes, int seed)
+{
+	int bufsz = 1 << 20;
+	char ebuf[bufsz];
+	char rbuf[bufsz];
+	char linkpath[NAME_MAX];
+	int fd, i;
+
+	sprintf(linkpath, "/proc/%d/fd/%d", getpid(), fildes);
+
+	fd = open(linkpath, O_RDONLY | O_LARGEFILE);
+	if (fd < 0) {
+		pr_perror("Cannot open unlinked file %s\n", linkpath);
+		exit(1);
+	}
+
+	memset(ebuf, 0, bufsz);
+
+	for (i = 0; i < (FSIZE >> 20); i++) {
+
+		if (read(fd, rbuf, bufsz) != bufsz) {
+			pr_perror("Cannot read %i bytes from file\n", bufsz);
+			goto failed;
+		}
+
+		if (memcmp(&ebuf, &rbuf, bufsz)) {
+			pr_perror("Block %d: Data found in zeroed block\n", i);
+			goto failed;
+		}
+	}
+
+	create_check_pattern(ebuf, bufsz, seed);
+
+	if (read(fd, rbuf, bufsz) != bufsz) {
+		pr_perror("Cannot read %i bytes from file\n", bufsz);
+		goto failed;
+	}
+
+	if (memcmp(&ebuf, &rbuf, bufsz)) {
+		pr_perror("Control Block: Data mismatch detected\n");
+		goto failed;
+	}
+
+	close(fd);
+	return;
+failed:
+	close(fd);
+	exit(1);
+}
+
+void read_proc_fd_link(int fd, char *buf)
+{
+	ssize_t res;
+	char linkpath[NAME_MAX];
+
+	sprintf(linkpath, "/proc/%d/fd/%d", getpid(), fd);
+
+	res = readlink(linkpath, buf, NAME_MAX);
+	if (res < 0) {
+		pr_perror("Cannot read fd symlink %s\n", linkpath);
+		exit(1);
+	}
+}
+
+int create_unlinked_file(int fileno)
+{
+	int fd;
+	char buf[1 << 20];
+	char fnm[NAME_MAX];
+	int bufsz;
+
+	sprintf(fnm, "/unlinked%d", fileno);
+	fd = open(fnm, O_WRONLY | O_CREAT | O_TRUNC | O_LARGEFILE, 0644);
+	if (fd < 0) {
+		pr_perror("Cannot create file %s\n", fnm);
+		exit(1);
+	}
+	test_msg("Created file: %s, fd %d\n", fnm, fd);
+
+	if (lseek64(fd, FSIZE, SEEK_SET) < 0) {
+		pr_perror("Cannot seek to offset %llx\n", FSIZE);
+		goto failed;
+	}
+	test_msg("File positioning done, offset=%llx\n", FSIZE);
+
+	bufsz = sizeof(buf);
+	create_check_pattern(&buf[0], bufsz, fileno);
+	if (write(fd, buf, bufsz) != bufsz) {
+		pr_perror("Cannot write %i bytes to file\n", bufsz);
+		goto failed;
+	}
+	test_msg("%i bytes written to file\n", bufsz);
+
+	if (unlink(fnm) < 0) {
+		pr_perror("Cannot unlink file %s\n", fnm);
+		goto failed;
+	}
+	test_msg("File %s is unlinked\n", fnm);
+
+	return fd;
+failed:
+	unlink(fnm);
+	close(fd);
+	return -1;
+}
+
+int main(int argc, char **argv)
+{
+	int fd[NFILES] = {0};
+	char links[NFILES][NAME_MAX];
+	char link[NAME_MAX];
+	int count = 0;
+	int tempfd;
+
+	test_init(argc, argv);
+
+	/* We need to create 10 unlinked files, each is around 1GB in size */
+	for (count = 0; count < NFILES; count++) {
+
+		test_msg("Creating unlinked file %d/%d\n", count + 1, NFILES);
+		tempfd = create_unlinked_file(count);
+
+		if (tempfd < 0) {
+			pr_perror("Cannot create unlinked file %d/%d\n",
+				  count + 1, NFILES);
+			return 1;
+		}
+
+		memset(&links[count][0], 0, NAME_MAX);
+		read_proc_fd_link(tempfd, &links[count][0]);
+
+		fd[count] = tempfd;
+	}
+	test_msg("Created %d unlinked files\n", NFILES);
+
+	test_daemon();
+	test_msg("Test daemonized, PID %d\n", getpid());
+	test_waitsig();
+
+	test_msg("PID %d resumed, doing final checks...\n", getpid());
+
+	for (count = 0; count < NFILES; count++) {
+		test_msg("Processing fd #%d (%d)\n", count, fd[count]);
+
+		test_msg("Checking symlink consistency...\n");
+		memset(&link[0], 0, NAME_MAX);
+		read_proc_fd_link(fd[count], &link[0]);
+
+		if (strcmp(&links[count][0], &link[0])) {
+			pr_perror("Symlink target %s has changed to %s\n",
+				  links[count], link);
+			return 1;
+		}
+
+		test_msg("Checking file contents...\n");
+		compare_file_content(fd[count], count);
+
+		test_msg("Closing file descriptor...\n");
+		if (close(fd[count]) == -1) {
+			pr_perror("Close failed, errno %d\n", errno);
+			return 1;
+		}
+	}
+
+	pass();
+	return 0;
+}
diff --git a/test/zdtm/static/unlink_multiple_largefiles.desc b/test/zdtm/static/unlink_multiple_largefiles.desc
new file mode 100644
index 00000000..b4ab1a82
--- /dev/null
+++ b/test/zdtm/static/unlink_multiple_largefiles.desc
@@ -0,0 +1 @@
+{'flavor': 'ns uns', 'opts': '--ghost-limit 1G'}
-- 
2.15.0



More information about the CRIU mailing list