[CRIU] [PATCH] cr-service: require non-cooperative userfaultfd for lazy-pages

[Mike Rapoport]

On Thu, Aug 10, 2017 at 02:40:23PM +0300, Pavel Emelyanov wrote:
> On 08/10/2017 12:59 PM, Mike Rapoport wrote:
> > Pavel,
> > 
> > Any comments?
> 
> Oops, sorry :) Too many e-mails after vacation. Yes, I agree with that. The
> only thing that I'd like to see as incremental fix is saving the uffd and
> uffd-non-coop on kdat cache and using these values everywhere.

The kdat fields haven't changed. The only change is how cr-check and
cr-service treat them.
 
> Said that
> 
> Acked-by: Pavel Emelyanov <xemul at virtuozzo.com>
> 
> -- Pavel
> 
> > On Wed, Aug 09, 2017 at 09:21:31AM +0200, Adrian Reber wrote:
> >> On Wed, Aug 09, 2017 at 08:41:52AM +0300, Mike Rapoport wrote:
> >>> I've noticed that we don't really have RPC support for lazy-pages. I've
> >>> rechecked Adrian's pull request to runc and there is a requirement to run
> >>> lazy-pages daemon manually.
> >>> Do we want to add an RPC interface for lazy-pages?
> >>> Another possibility is to fork() lazy-pages from restore...
> >>
> >> I think fork()-ing makes sense. Except for debug situations there is no
> >> real reason to start the lazy-pages daemon manually.
> >>
> >> It would still be nice to have a way to start it manually, though. But
> >> the default should be that it fork()s.

And what about fork()ing lazy-pages when restore is run with --lazy-pages?

> >> 		Adrian
> >>
> > 
> 

-- 
Sincerely yours,
Mike.