[CRIU] [PATCH 0/18] Support descriptors sent over unix sockets (v2)

Kirill Tkhai ktkhai at virtuozzo.com
Fri Aug 4 18:33:28 MSK 2017



On 03.08.2017 21:15, Pavel Emelyanov wrote:
> On 07/31/2017 12:05 PM, Kirill Tkhai wrote:
>> On 22.07.2017 03:48, Andrei Vagin wrote:
>>> On Mon, Jul 10, 2017 at 05:35:21PM -0700, Andrei Vagin wrote:
>>>> Kirill, could you review this series?
>>>
>>> Kirill, what is your verdict?
>>
>> There were several commentaries by me, which are approved by Pavel and some
>> are not approved. I thought, he is going to make the changes on the approved
>> ones, isn't he?
> 
> I've done them, everything I've agreed on is in [PATCH 18/18 v2] (and patch #11
> is no longer required).

Yeah, and here is my Reviewed-by for 1-10 and 12-17.
 
>>>>
>>>> On Mon, Jul 10, 2017 at 12:37:28PM +0300, Pavel Emelyanov wrote:
>>>>> It turned out, that the idea about all files having unique IDs was wrong,
>>>>> fifos and ttys generate reg-file entry for themselves with the same ID.
>>>>>
>>>>> Also, dgram unix sockets can be connected to self, and this wasn't handled
>>>>> in unix peer resolution fixlets.
>>>>>
>>>>> So here's the v2 with the above stuff taken into account. I've added two
>>>>> patches to make fifo and tty IDs unique, fixed find_file_desc() to count
>>>>> for that and tuned unix peer resolve changes to handle self-connected
>>>>> dgram sockets. And rebased on recent criu-dev of course.
>>>>>
>>>>> https://travis-ci.org/xemul/criu/builds/251242054
>>>>>
>>>>> -- Pavel
>>>>> _______________________________________________
>>>>> CRIU mailing list
>>>>> CRIU at openvz.org
>>>>> https://lists.openvz.org/mailman/listinfo/criu
>>>> _______________________________________________
>>>> CRIU mailing list
>>>> CRIU at openvz.org
>>>> https://lists.openvz.org/mailman/listinfo/criu
>> .
>>
> 


More information about the CRIU mailing list