[CRIU] [PATCH 0/2] soccr: includes cleanup

Dmitry Safonov dsafonov at virtuozzo.com
Fri Apr 28 11:28:36 PDT 2017


So, while working on some issue, I've included "parasite-service.h"
header and there was a compilation error: that header used something
from other header, which I haven't included in this C file.
What a pitfall!

So, I came to this tool named "Include What You Use":
https://github.com/include-what-you-use/include-what-you-use

With some little hackery to makefiles I ran it on .h, .c files.

For the beginning here are simple patches for soccr library.
I've ran it over compel also, but yet didn't split result on
formatted patches set.

Dmitry Safonov (2):
  soccr.h: use uint32_t instead of __u32
  soccr: clean a bit includes list

 soccr/soccr.c | 10 ++++------
 soccr/soccr.h | 45 ++++++++++++++++++++++-----------------------
 2 files changed, 26 insertions(+), 29 deletions(-)

-- 
2.12.2



More information about the CRIU mailing list