[CRIU] [PATCH 0/5] Speed up kdat checks (v2)

Dmitry Safonov 0x7f454c46 at gmail.com
Wed Apr 26 03:26:17 PDT 2017


2017-04-26 12:23 GMT+03:00 Pavel Emelyanov <xemul at virtuozzo.com>:
> In the previous discussion it was suggested not to compile-in
> the kdat bits, but rather cache them in some place, that gets
> evicted on node reboot.
>
> Here's how this can look like.
>
> Briefly -- when kerndat.c has finished auto-detection is writes
> the kdat variable into the /run/criu.kdat file. On the next
> start the file in question is loaded into memory (if present)
> as is.
>
> As the next step we can move the cpu_init() stuff into kdat and
> (as Dima suggested) vdso_init().

Looks good to me,
Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>

But I also suggest adding CRIU_GITID to that file (somewhere
at the beginning). So, if CRIU package has been updated and
kerndat_s was changed - to check the version and regenerate a file.

-- 
             Dmitry


More information about the CRIU mailing list