[CRIU] [PATCH 0/12] Speed up kdat checks

Mike Rapoport rppt at linux.vnet.ibm.com
Tue Apr 25 22:30:10 PDT 2017


Hi,

On Mon, Apr 24, 2017 at 11:06:01PM +0300, Pavel Emelyanov wrote:
> Hi
> 
> I've been experimenting with criu restore times recently and the first
> thing I've met was -- criu does a lot of slow checks on start in kerndat.c.
> 
> Here's the proposal (not extremely elegant, though) how to fix this.
> 
> We have a .config which is created empty on default built, but anyone can
> put data into it and they will result in CONFIG_BLAH_BLAH propagates into
> criu sources.
> 
> The proposal is to introduce a set of config options for those kerndat.c
> checks, that are "immutable" for a given node. Examples are in patches :)
> 
> Also I've created the scripts/mklocalconfig.sh script that creates a
> .config for local node. To determine some of the options the script runs
> 'criu check --feature foo' command, which is ... not very nice, as one
> need to build criu twice -- once to get "default" criu, then to get
> configured criu.
> 
> Suggestions on improving this are very welcome.

Sorry, only criticism ;-)

Compile time configuration only helps those who build criu from source.
Distros will have to keep run-time detection for everything and whoever
installs criu from distro packages will gain nothing :(

The only idea I have now is something like '/etc/criu/kdat.conf'. It can be
generated, e.g. at package post-install time and then read at run-time to
set the kdat fields...

> 
> -- Pavel

--
Sincerely yours,
Mike.



More information about the CRIU mailing list