[CRIU] [PATCH] make: don't run feature-tests for tags/etags/cscope

Kirill Tkhai ktkhai at virtuozzo.com
Mon Apr 24 06:28:58 PDT 2017


On 24.04.2017 15:51, Dmitry Safonov wrote:
> Each `make tags` resulted in running feature-tests.
> That's not needed for tags generation.
> Don't waste time on tests as we don't compile anything.
> 
> Reported-by: Kirill Tkhai <ktkhai at virtuozzo.com>
> Signed-off-by: Dmitry Safonov <dsafonov at virtuozzo.com>

Tested-by: Kirill Tkhai <ktkhai at virtuozzo.com>

I was more wondered that I had libc6-dev-i386 installed, while the Makefile
said, I don't have. I didn't investigated the real Makefile reason. So,
also we may add small change like below:
---
diff --git a/Makefile.config b/Makefile.config
index 0dd9d043..35e1077e 100644
--- a/Makefile.config
+++ b/Makefile.config
@@ -26,7 +26,7 @@ ifeq ($(call try-cc,$(FEATURE_TEST_X86_COMPAT),-m32),true)
         FEATURE_DEFINES	+= -DCONFIG_COMPAT
 else
         $(info Note: Building without ia32 C/R, missed packages:)
-        $(info $(info)      libc6-dev-i386, gcc-multilib)
+        $(info $(info)      libc6-dev-i386 or gcc-multilib)
 endif
 endif
 




More information about the CRIU mailing list