[CRIU] [PATCH 15/18] sk-unix: Don't warn if nothing to unlink

Cyrill Gorcunov gorcunov at gmail.com
Mon Apr 24 03:58:25 PDT 2017


On Mon, Apr 24, 2017 at 01:44:20PM +0300, Kirill Tkhai wrote:
> > 
> > diff --git a/criu/sk-unix.c b/criu/sk-unix.c
> > index c7aa3099c00c..6178dd97312c 100644
> > --- a/criu/sk-unix.c
> > +++ b/criu/sk-unix.c
> > @@ -1386,7 +1386,7 @@ static void unlink_stale(struct unix_sk_info *ui)
> >  		return;
> >  
> >  	ret = unlinkat(AT_FDCWD, ui->name, 0) ? -1 : 0;
> 
> It's not a question to your patch, but Q in general list: what if there is a regular file
> on the place of deleted unix socket?

Good point. Strictly speaking we need to check if it's socket
indeed, will do on top.

Note there are another number of patches on top for this series,
because we've spotted a few nits on unix code during containers
testing. Will send them later.


More information about the CRIU mailing list