[CRIU] [PATCH] net: set the root net ns after restoring all namespaces

Kirill Tkhai ktkhai at virtuozzo.com
Mon Apr 24 02:33:03 PDT 2017


On 22.04.2017 04:11, Andrei Vagin wrote:
> On Wed, Mar 29, 2017 at 01:25:48PM +0300, Kirill Tkhai wrote:
>> On 29.03.2017 12:38, Kirill Tkhai wrote:
>>> On 28.03.2017 22:56, Andrei Vagin wrote:
>>>> From: Andrei Vagin <avagin at virtuozzo.com>
>>>>
>>>> Then we will create transport sockets and we want to know where
>>>> they will be created.
>>>>
>>>> Cc: Kirill Tkhai <ktkhai at virtuozzo.com>
>>>> Signed-off-by: Andrei Vagin <avagin at virtuozzo.com>
>>>
>>> Looks good for me. Thanks.
>>>
>>> Reviewed-by: Kirill Tkhai <ktkhai at virtuozzo.com>
>>>
>>> Though, the issue with tun still remains. The patch below for reproduction
>>
>> Andrew, I tried to move my patch set on this patch. It is moved not good:
>> we get new rule of order of generation of net namespaces and creation of
>> transport socket in usernsd. It would be more clear for further code writing
>> if we stay in criu net. Maybe we stay there? I suggest to call the whole
>> prepare_net_namespaces() functionality in separate function like here:
> 
> It looks ok for me. Could you prepare a patch?

It's patch "[PATCH v3 01/55] ns: Do not change net_ns in prepare_net_namespaces()"
from nested pid namespaces series.


More information about the CRIU mailing list