[CRIU] criu check --extra output and dump failure

[Dmitry Safonov]

2017-04-18 18:26 GMT+03:00 Brinkmann, Harald
<Harald.Brinkmann at bst-international.com>:
>
> On Tue, 2017-04-18 at 17:58 +0300, Dmitry Safonov wrote:
>> > compel/Makefile:44: HOSTCFLAGS are -I__BUILD_HOST__/platform-imx6/sysroot-host/lib/pkgconfig/../../include -march=armv7-a -march=armv7-a -O2 -g -Wall -Wformat-security -Werror -DCONFIG_ARMV7 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE  -iquote include/  -DNO_RELOCS
>>
>> Here is in the host's CFLAGS "-march=armv7-a" - that looks wrong.
>> Please, run instead with attached diff - it should fix this problem.
>
> I have run this with both diffs applied. Still no joy. This looks OK:
>
> compel/Makefile:42: host-ccflags-y are -DINCLUDEDIR=\"/usr/local/include\" -DLIBEXECDIR=\"/usr/local/libexec\" -DLIBDIR=\"/usr/local/lib/x86_64-linux-gnu\" -DSTATIC_LIB=\"libcompel.a\" -DDYN_LIB=\"libcompel.so.1\" -iquote compel/arch/arm/src/lib/include -iquote compel/include -fno-strict-aliasing -fPIC -I compel/include/uapi
> compel/Makefile:43: ccflags-y are -DINCLUDEDIR=\"/usr/local/include\" -DLIBEXECDIR=\"/usr/local/libexec\" -DLIBDIR=\"/usr/local/lib/x86_64-linux-gnu\" -DSTATIC_LIB=\"libcompel.a\" -DDYN_LIB=\"libcompel.so.1\" -iquote compel/arch/arm/src/lib/include -iquote compel/include -fno-strict-aliasing -fPIC -I compel/include/uapi
> compel/Makefile:44: HOSTCFLAGS are -I/home/brih/dev/ptx/ps5000.BSP/platform-imx6/sysroot-host/lib/pkgconfig/../../include  -DNO_RELOCS
>
> But I then get this:
>
> gcc -M -MT compel/src/main-host.d -MT compel/src/main-host.o -I/home/brih/dev/ptx/ps5000.BSP/platform-imx6/sysroot-host/lib/pkgconfig/../../include -DNO_RELOCS -DINCLUDEDIR=\"/usr/local/include\" -DLIBEXECDIR=\"/usr/local/libexec\" -DLIBDIR=\"/usr/local/lib/x86_64-linux-gnu\" -DSTATIC_LIB=\"libcompel.a\" -DDYN_LIB=\"libcompel.so.1\" -iquote compel/arch/arm/src/lib/include -iquote compel/include -fno-strict-aliasing -fPIC -I compel/include/uapi compel/src/main-host.c -o compel/src/main-host.d
> compel/src/main-host.c:56:2: error: #error "CONFIG_<ARCH> not defined, or unsupported ARCH"
>  #error "CONFIG_<ARCH> not defined, or unsupported ARCH"
>   ^
> compel/src/main-host.c:56:2: error: #error "CONFIG_<ARCH> not defined, or unsupported ARCH"
>  #error "CONFIG_<ARCH> not defined, or unsupported ARCH"
>   ^

Oh, well, here we go :)
Please, shot with a new diff.

-- 
             Dmitry
-------------- next part --------------
diff --git a/Makefile b/Makefile
index 385a4d096835..6405e6c76351 100644
--- a/Makefile
+++ b/Makefile
@@ -16,7 +16,9 @@ include $(__nmk_dir)macro.mk
 CFLAGS		+= $(USERCFLAGS)
 export CFLAGS
 
-HOSTCFLAGS	?= $(CFLAGS)
+ifeq ($(origin HOSTCFLAGS), undefined)
+        HOSTCFLAGS := $(CFLAGS)
+endif
 export HOSTCFLAGS
 
 #
@@ -137,6 +139,7 @@ export GMON GMONLDOPT
 endif
 
 CFLAGS			+= $(WARNINGS) $(DEFINES) -iquote include/
+HOSTCFLAGS		+= $(WARNINGS) $(DEFINES) -iquote include/
 
 # Default target
 all: criu lib