[CRIU] [PATCH 2/6] compel: cli -- Add more flags into cflags report

Dmitry Safonov 0x7f454c46 at gmail.com
Thu Sep 29 04:57:42 PDT 2016


2016-09-29 14:51 GMT+03:00 Cyrill Gorcunov <gorcunov at gmail.com>:
> On Thu, Sep 29, 2016 at 02:48:57PM +0300, Dmitry Safonov wrote:
>> 2016-09-29 0:34 GMT+03:00 Cyrill Gorcunov <gorcunov at openvz.org>:
>> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>
>> Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>
>>
>> It'll need some more changes, I belive (i.e., ldflags for arm/arm64
>> should be without '-r').
>> Anyway, that all can go on top later.
>
> For sure. Since I don't have access to other archs for a while
> I implement it for x86

I also think, that some cflags we should add in Makefile to this output,
than to handle all there: we _could_ change _nopic to have "-m32",
as it's used only for 32-bits, add " -m elf_i386" to ldflags output for ia32,
but I think that's better to do in make, as it's right for compile/linking on
64-bits host.

-- 
             Dmitry


More information about the CRIU mailing list