[CRIU] [PATCH 0/3] Build fixups

Dmitry Safonov dsafonov at virtuozzo.com
Fri Sep 23 07:41:29 PDT 2016


On 09/23/2016 05:20 PM, Dmitry Safonov wrote:
> Uncleaned compat files, as they are under CONFIG_COMPAT option,
> which is feature-test option. Feature-tests are not run on
> clean/mrproper - set this kind of build options on cleaning.
> Add test for mrproper work.
> Add libsoccr in CRIU's objects deps (fixes build on Travis).
>
> Yet Alpine build fails in libsoccr after patches.
>
> Dmitry Safonov (3):
>   make: define CONFIG_COMPAT on mrproper/clean
>   Travis: check mrproper cleanings
>   make, soccr: let CRIU depend on libsoccr
>
>  Makefile                      | 2 +-
>  criu/Makefile                 | 3 +++
>  scripts/build/Dockerfile.tmpl | 2 ++
>  3 files changed, 6 insertions(+), 1 deletion(-)
>

I think, maybe it's worth to move feature-test upper - near top-Make.
For now, build on Alpine fails because libsoccr builds before
CRIU, which build handles feature-tests now:
https://travis-ci.org/0x7f454c46/criu/jobs/162209526

The other option would be -- introduce libsoccr's and other
subprojects's feature-tests, which may and will copy CRIU's
feature tests - I think, moving them on top is better.

So we will have like global CONFIG_HAS_* defines.
Cyrill, Pavel, what do you think?

-- 
              Dmitry


More information about the CRIU mailing list