[CRIU] [PATCH 3/6] ip xfrm state: add save/restore

Stephen Hemminger stephen at networkplumber.org
Tue Sep 20 09:43:31 PDT 2016


On Fri,  2 Sep 2016 12:02:23 +0300
Pavel Tikhomirov <ptikhomirov at virtuozzo.com> wrote:

> +static __u32 state_dump_magic = 0x71706987;
> +
> +static int xfrm_state_list_deleteall_or_save(int argc, char **argv, int deleteall, int save)

I have no problem with the overall functionality of this patch set, but this
function_name_is_too_long_for_rational_humans.

Please make the function names (especially the local static ones) shorter and more reasonable
and resubmit


More information about the CRIU mailing list