[CRIU] [PATCH 0/6] Try to sanitize mem dump and pages xfer mess a bit

Mike Rapoport rppt at linux.vnet.ibm.com
Mon Sep 19 23:34:10 PDT 2016


On Mon, Sep 19, 2016 at 02:16:23PM +0300, Pavel Emelyanov wrote:
> With the ability to do pre- and post- dumps and transfers the
> amount of bool-s, if-s and constants become too big.
> 
> Here's an attempt to lower this diversity :)

With the series applied, gcc-4.8 (4.8.4-2ubuntu1~14.04.3) fails:

  CC       criu/page-xfer.o
In file included from /home/mike/git/criu/criu/include/log.h:6:0,
                 from /home/mike/git/criu/criu/include/bug.h:8,
                 from /home/mike/git/criu/criu/include/image.h:12,
                 from criu/page-xfer.c:13:
criu/page-xfer.c: In function ‘write_pagemap_to_server’:
/home/mike/git/criu/criu/include/criu-log.h:62:16: error: ‘cmd’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
  print_on_level(LOG_ERROR,     \
                ^
criu/page-xfer.c:118:6: note: ‘cmd’ was declared here
  u32 cmd;
      ^
cc1: all warnings being treated as errors
make[2]: *** [criu/page-xfer.o] Error 1

One more comment is in reply to "[PATCH 6/6] mem: Cleanup dumping pages
controls"

Otherwise

Acked-by: Mike Rapoport <rppt at linux.vnet.ibm.com>

--
Sincerely yours,
Mike.



More information about the CRIU mailing list