[CRIU] [PATCH] compel: abort PIE generation on undefined/external symbols

Dmitry Safonov dsafonov at virtuozzo.com
Fri Sep 16 06:24:38 PDT 2016


On 09/16/2016 03:27 PM, Cyrill Gorcunov wrote:
> On Fri, Sep 16, 2016 at 03:04:10PM +0300, Dmitry Safonov wrote:
>> As we meet this before, I think, we should abort generation here.
>> No point for making PIE with external symbols for us (at least, yet),
>> so let's break build than find the problem at runtime.
>>
>> Cc: Cyrill Gorcunov <gorcunov at openvz.org>
>> Signed-off-by: Dmitry Safonov <dsafonov at virtuozzo.com>
> Acked-by: Cyrill Gorcunov <gorcunov at openvz.org>
>
> It might trigger false positive in got-table symbol i guess, but
> lets better review every problem instead of silently continue
> generating blob.
>

Oh, well, you right - that will not work (looking at Travis - on my env
that passed).
I'll resend v2 with patch that just adds warning for that case.

-- 
              Dmitry


More information about the CRIU mailing list