[CRIU] [PATCH] compel: abort PIE generation on undefined/external symbols

Dmitry Safonov dsafonov at virtuozzo.com
Fri Sep 16 05:04:10 PDT 2016


As we meet this before, I think, we should abort generation here.
No point for making PIE with external symbols for us (at least, yet),
so let's break build than find the problem at runtime.

Cc: Cyrill Gorcunov <gorcunov at openvz.org>
Signed-off-by: Dmitry Safonov <dsafonov at virtuozzo.com>
---
 compel/handle-elf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/compel/handle-elf.c b/compel/handle-elf.c
index 64616f978d87..f4a064726ad9 100644
--- a/compel/handle-elf.c
+++ b/compel/handle-elf.c
@@ -319,7 +319,8 @@ int __handle_elf(void *mem, size_t size)
 					goto err;
 				}
 #else
-				continue;
+				pr_err("Unexpected undefined symbol: `%s'. External symbol in PIE?\n", name);
+				goto err;
 #endif
 			}
 
-- 
2.9.0



More information about the CRIU mailing list