[CRIU] [PATCH 02/11] images: sk-packet -- Reserve data for netlink queue support

Pavel Emelyanov xemul at virtuozzo.com
Tue Sep 13 08:14:56 PDT 2016


On 09/13/2016 12:09 PM, Cyrill Gorcunov wrote:
> On Fri, Aug 5, 2016 at 11:59 PM, Cyrill Gorcunov <gorcunov at gmail.com> wrote:
>> On Fri, Aug 05, 2016 at 12:45:21PM -0700, Andrey Vagin wrote:
>>>> Wait. Have you added some more field in protobuf message?
>>>> Currently only @addr field is present in vz7 criu in compare
>>>> with vanilla one.
>>>
>>> addr is an array of bytes and I saved a whole addr there. It is
>>> intersting question how do we save an addres for unix messages, if a
>>> sender doesn't exist (have been closed).
>>
>> Andrew, my main concern is not about how will you extend/fix code
>> or whatever -- what I mean is that we need to sync our images
>> produced by vz7 and vanilla, so we won't hit the compatibility
>> problem. Please check vz7 sources code and vanilla one and
>> tell me what else we should add/delete or anything to safe
>> ourselves.
> 
> Guys, can we merge this patch please? This field is present in vz7
> release and it may conflict with future vanilla releases, which is
> unacceptable.

I asked whether the new field identifies the sender and, if it does,
align this with Kirill Tkhai's patches to add sender id for unix sockets
as well.

-- Pavel



More information about the CRIU mailing list