[CRIU] [PATCH] cgroup: fix potential null dereference
Tycho Andersen
tycho.andersen at canonical.com
Mon Sep 12 08:55:51 PDT 2016
new_controller() returns NULL on error, so let's check for that.
Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
---
criu/cgroup.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/criu/cgroup.c b/criu/cgroup.c
index 431ba30..0869118 100644
--- a/criu/cgroup.c
+++ b/criu/cgroup.c
@@ -567,7 +567,11 @@ static int collect_cgroups(struct list_head *ctls)
pr_err("controller %s not found\n", cc->name);
return -1;
} else {
- struct cg_controller *nc = new_controller(cc->name);
+ struct cg_controller *nc;
+
+ nc = new_controller(cc->name);
+ if (!nc)
+ return -1;
list_add_tail(&nc->l, &cg->l);
n_cgroups++;
current_controller = nc;
--
2.7.4
More information about the CRIU
mailing list