[CRIU] [PATCH RFC v3 2/4] mem: Introduce image-proxy/image-cache & remote option

[Rodrigo Bruno]

Hi,

> Hi,
> 
> sorry for the delayed response. I adjusted your comments and decided
> to check the issue about the tests with namespaces later
> (https://lists.openvz.org/pipermail/criu/2016-August/030993.html) and
> send a fix in a separate commit. So for the time being I have this in zdtm.py:
> 
> if opts['remote']:
>      run_flavs -= set(['ns', 'uns'])
> 
> So I ran the zdtm tests with --remote option enabled and I hit an error like:
> === Run 3/260 ----------------
> Skipping zdtm/transition/netlink00 (manual run only)
> 
> ====================== Run zdtm/transition/unix_sock in h ======================
> Start test
> ./unix_sock --pidfile=unix_sock.pid --outfile=unix_sock.out
> --filename=unix_sock.test
> criu: no process found
> Adding image cache
> Adding image proxy
> Run criu dump
> Run criu restore
> =[log]=> dump/zdtm/transition/unix_sock/24/1/restore.log
> ------------------------ grep Error ------------------------
> (00.021562)     24: Error (criu/sk-queue.c:48): Unable to change an
> image offset: Illegal seek
> (00.021631) Error (criu/cr-restore.c:1998): Restoring FAILED.
> ------------------------ ERROR OVER ------------------------
> ############# Test zdtm/transition/unix_sock FAIL at CRIU restore ##############
> 
> I guess that's because we are not allowed to lseek on the socket. Any
> advice how to proceed with this?

it has been a while since I looked at this code but I remember that sometimes I would
simply read from the socket and discard its contents until I read the number of bytes
fseek would like me to advance in a regular file.

This is only applicable if you know that fseek is only used to 'move forward'. At that
time I could not find any use where fseek would try to 'move backwards'. Am I wrong?

I hope that helps...

cheers,
rodrigo
-- 
Rodrigo Bruno <rbruno at gsd.inesc-id.pt>