[CRIU] [PATCH 3/6] criu: pagemap: replace 'zero' and 'lazy' booleans with 'flags'

[Dmitry Safonov]

2016-09-08 16:13 GMT+03:00 Mike Rapoport <rppt at linux.vnet.ibm.com>:
> On Thu, Sep 08, 2016 at 03:33:58PM +0300, Dmitry Safonov wrote:
>> 2016-09-08 10:39 GMT+03:00 Mike Rapoport <rppt at linux.vnet.ibm.com>:
>> > --- a/images/pagemap.proto
>> > +++ b/images/pagemap.proto
>> > @@ -10,6 +10,5 @@ message pagemap_entry {
>> >         required uint64 vaddr           = 1 [(criu).hex = true];
>> >         required uint32 nr_pages        = 2;
>> >         optional bool   in_parent       = 3;
>> > -       optional bool   zero            = 4;
>> > -       optional bool   lazy            = 5;
>> > +       optional uint32 flags           = 4 [(criu).hex = true];
>> >  }
>>
>> Not sure that protobuf will correctly understand this change.
>> Maybe comment out zero and lazy fields, preserving their tag
>> number? And introduce flags with tag #6.
>> Also it's possible to preserve zero&lazy with names like
>> DEPRICATED_{zero,lazy} instead commenting them out.
>
> I believe that since neither 'zero' nor 'lazy' never have been in master,
> it's not a problem to break compatibility here and just replace 'zero' and
> 'lazy' with flags at this point in time.

Ok, right, thanks.