[CRIU] [PATCH 2/4] ppc64/restore.h: fix for clang

Laurent Dufour ldufour at linux.vnet.ibm.com
Thu Oct 27 01:00:22 PDT 2016


On 26/10/2016 07:08, Kir Kolyshkin wrote:
> Apparently, clang 3.8 ppc doesn't know the register name 'sp'.
> 
>> criu/cr-restore.c:3179:2: error: unknown register name 'sp' in asm
>>         JUMP_TO_RESTORER_BLOB(new_sp, restore_task_exec_start,
>> task_args);
>>         ^
>> /criu/criu/arch/ppc64/include/asm/restore.h:24:5: note: expanded from
>> macro 'JUMP_TO_RESTORER_BLOB'
>>                 : "sp", "1", "2", "3", "12", "memory")
>>                   ^
>> 1 error generated.
> 
> According to docs, stack pointer is r1.

Acked-by: Laurent Dufour <ldufour at linux.vnet.ibm.com>

> Cc: Laurent Dufour <ldufour at linux.vnet.ibm.com>
> Signed-off-by: Kir Kolyshkin <kir at openvz.org>
> ---
>  criu/arch/ppc64/include/asm/restore.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/criu/arch/ppc64/include/asm/restore.h b/criu/arch/ppc64/include/asm/restore.h
> index 7e35943..bac7bb5 100644
> --- a/criu/arch/ppc64/include/asm/restore.h
> +++ b/criu/arch/ppc64/include/asm/restore.h
> @@ -21,7 +21,7 @@
>  		: "r"(new_sp),						\
>  		  "r"((unsigned long)restore_task_exec_start),		\
>  		  "r"(task_args)					\
> -		: "sp", "1", "2", "3", "12", "memory")
> +		: "r1", "1", "2", "3", "12", "memory")
> 
>  /* There is nothing to do since TLS is accessed through r13 */
>  #define core_get_tls(pcore, ptls)
> 



More information about the CRIU mailing list