[CRIU] [PATCH 10/10] common: Move page.h in

Pavel Emelyanov xemul at virtuozzo.com
Tue Oct 25 04:37:11 PDT 2016


On 10/25/2016 11:43 AM, Cyrill Gorcunov wrote:
> On Mon, Oct 24, 2016 at 02:58:10PM +0300, Cyrill Gorcunov wrote:
>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> 
> Pavel, page.h rather should be exported by compel, because
> 
> static inline unsigned long task_size(void)
> {
> 	unsigned long task_size;
> 
> 	for (task_size = TASK_SIZE_MIN; task_size < TASK_SIZE_MAX; task_size += SZ_1G)
> 		if (munmap((void *)task_size, page_size()))
> 			break;
> 
> 	return task_size;
> }

No, this means that task_size() should be in compel/task_size.h which
in turn includes common/page.h

> and the task_size is exported via uapi/compel/asm/types.h. So drop this
> particular patch please. I'll move page.h into compel, as it were before.
> .
> 



More information about the CRIU mailing list