[CRIU] [PATCH 2/3] compel: rm -fno-jump-tables from CFLAGS

Kir Kolyshkin kir at openvz.org
Thu Oct 20 20:02:27 PDT 2016


Three reasons:
1. this flag doesn't work for ppc64 (see commit dc7b08b);
2. clang is not aware of this flag;
3. all seems to work just fine without it.

Cc: Laurent Dufour <ldufour at linux.vnet.ibm.com>
Cc: Cyrill Gorcunov <gorcunov at openvz.org>
Signed-off-by: Kir Kolyshkin <kir at openvz.org>
---
 compel/src/main.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/compel/src/main.c b/compel/src/main.c
index a30321b..625ae11 100644
--- a/compel/src/main.c
+++ b/compel/src/main.c
@@ -19,9 +19,8 @@
 	"-Wstrict-prototypes "					\
 	"-fno-stack-protector -nostdlib -fomit-frame-pointer "
 
-#define COMPEL_CFLAGS_PIE	CFLAGS_DEFAULT_SET "-fpie -fno-jump-tables"
-#define COMPEL_CFLAGS_PIE_JPT	CFLAGS_DEFAULT_SET "-fpie"
-#define COMPEL_CFLAGS_NOPIC	CFLAGS_DEFAULT_SET "-fno-pic -fno-jump-tables"
+#define COMPEL_CFLAGS_PIE	CFLAGS_DEFAULT_SET "-fpie"
+#define COMPEL_CFLAGS_NOPIC	CFLAGS_DEFAULT_SET "-fno-pic"
 
 #define COMPEL_LDFLAGS_DEFAULT "-r -z noexecstack"
 
@@ -111,7 +110,7 @@ int main(int argc, char *argv[])
 			.cflags	= COMPEL_CFLAGS_PIE,
 		}, {
 			.arch	= "ppc64",
-			.cflags	= COMPEL_CFLAGS_PIE_JPT,
+			.cflags	= COMPEL_CFLAGS_PIE,
 		},
 	};
 
-- 
2.7.4



More information about the CRIU mailing list