[CRIU] [PATCH] x86, tls: read no more than saved TLS entries

Cyrill Gorcunov gorcunov at gmail.com
Thu Oct 20 06:31:35 PDT 2016


On Thu, Oct 20, 2016 at 03:31:00PM +0300, Dmitry Safonov wrote:
>   While writing this, I somehow managed to miss the check of
> how many entries were saved in core image.
> So it may dereference here bs.
> 
> Fixes: #228
> Fixes: commit 6fde3b8c27db ("x86: restore TLS")
> 
> Cc: Andrei Vagin <avagin at virtuozzo.com>
> Cc: Cyrill Gorcunov <gorcunov at openvz.org>
> Reported-by: Andrei Vagin <avagin at virtuozzo.com>
> Signed-off-by: Dmitry Safonov <dsafonov at virtuozzo.com>

You mean we can simply ignore existing tls in image? O_o
Either we should check if they are present at all either
interrupt restore if the number mismatch. I think simply
ignore is not an option here.


More information about the CRIU mailing list