[CRIU] ✗ travis-ci: failure for series starting with [v2,1/6] net: pass the struct nlattrs to dump() functions

[Tycho Andersen]

On Thu, Oct 13, 2016 at 08:18:11PM +0300, Dmitry Safonov wrote:
> 2016-10-13 20:15 GMT+03:00 Dmitry Safonov <0x7f454c46 at gmail.com>:
> > 2016-10-13 19:45 GMT+03:00 Tycho Andersen <tycho.andersen at canonical.com>:
> >> On Thu, Oct 13, 2016 at 04:30:07PM -0000, Patchwork wrote:
> >>> == Series Details ==
> >>>
> >>> Series: series starting with [v2,1/6] net: pass the struct nlattrs to dump() functions
> >>> URL   : https://patchwork.criu.org/series/672/
> >>> State : failure
> >>>
> >>> == Logs ==
> >>>
> >>> For more details see: https://travis-ci.org/criupatchwork/criu/builds/167395342
> >>
> >> Hmm. Looks like not everything has linux/net_namespace.h? And alpine's
> >> net/if.h looks broken:
> >> https://travis-ci.org/criupatchwork/criu/jobs/167395349
> >>
> >> I'll see what to do about the net_namespace.h thing, but I don't know
> >> what to do about a broken header :(
> >
> > It's easy: add your feature test and ifdef option like CONFIG_HAS
> > (check Makefile.config, scripts/feature-tests.mak).
> > So, you can define structs that are missing or hide them under ifdefs.
> 
> You may have as an example CONFIG_HAS_TCP_REPAIR_WINDOW,
> or any other CRIU's CONFIG_HAS_*

Yeah, I think that's what we need for linux/net_namespace.h. It looks
like the other one is my fault:

http://stackoverflow.com/questions/8755030/whats-wrong-with-linux-if-h-and-net-if-h

we can just include sys/types.h and get IFF_UP; i'll send a v4 with
that shortly.

Tycho