[CRIU] [PATCH 05/23] Makefiles: move -Wa, --noexecstack out of CFLAGS

Cyrill Gorcunov gorcunov at gmail.com
Thu Oct 13 05:24:33 PDT 2016


On Thu, Oct 13, 2016 at 03:19:27PM +0300, Pavel Emelyanov wrote:
> On 10/12/2016 04:46 AM, Kir Kolyshkin wrote:
> > The problem is, -Wa is a flag for assembler, but CFLAGS are also used
> > to generate dependencies, and clang complains loudly when it is used
> > for deps:
> > 
> >>   DEP      compel/arch/x86/plugins/std/syscalls-64.d
> >>  clang-3.8: error: argument unused during compilation:
> >> '-Wa,--noexecstack'
> > 
> > This patch moved the noexecflag from assembler to linker. I am not
> > 100% sure but the end result seems to be the same.
> 
> Cyrill, Dima what would you say?

SHould not cause problems I think.
Reviewed-by: Cyrill Gorcunov <gorcunov at openvz.org>



More information about the CRIU mailing list